Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography #29

Open
JoeyPearlmanHennepin opened this issue Jan 3, 2024 · 1 comment
Open

Typography #29

JoeyPearlmanHennepin opened this issue Jan 3, 2024 · 1 comment

Comments

@JoeyPearlmanHennepin
Copy link
Collaborator

JoeyPearlmanHennepin commented Jan 3, 2024

Use this issue to discuss typography in the HenenpinCounty.gov design system.

Discussion from other design systems
alphagov/govuk-design-system-backlog#64

Articles and resources
https://designnotes.blog.gov.uk/2018/02/19/developing-new-typography-and-spacing-for-gov-uk-frontend/
https://typescale.com/
http://webtypography.net/toc/
https://prowebtype.com/
https://practicaltypography.com/introduction.html

@JoeyPearlmanHennepin
Copy link
Collaborator Author

JoeyPearlmanHennepin commented Jan 3, 2024

Todo list

  • Review typescales for mobile and desktop
    • Should we use a single scale for mobile and desktop, or allow desktop to grow larger than mobile?
  • Review margin for mobile and desktop
    • What margins should we use for each heading or text style?
    • Should we use both top and bottom margins, or should we only apply margins in one direction to avoid margin collapse?
    • Should fieldset and fieldset legend text styles be defined in Typography or a different primitives file?
    • Should formgroup be defined in typography, or in a different file since it only affects margin and not typographic styling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant