Tweaked test and added NEWS entry [PR #27]

HenrikBengtsson · May 14, 2015 · 2cba115 · 2cba115
1 parent b41ccc5
commit 2cba115
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,10 +1,18 @@
 Package: matrixStats
 Version: 0.14.0-9000
-Depends: R (>= 2.9.0)
-Imports: methods
-Suggests: R.rsp, microbenchmark, R.devices, base64enc, ggplot2, knitr
+Depends:
+  R (>= 2.9.0)
+Imports:
+  methods
+Suggests:
+  base64enc,
+  ggplot2,
+  knitr,
+  microbenchmark,
+  R.devices,
+  R.rsp
 VignetteBuilder: R.rsp
-Date: 2015-03-02
+Date: 2015-05-13
 Title: Methods that Apply to Rows and Columns of Matrices (and to Vectors)
 Authors@R: c(
   person("Henrik", "Bengtsson", role=c("aut", "cre", "cph"),

diff --git a/NEWS b/NEWS
@@ -1,6 +1,15 @@
 Package: matrixStats
 ====================
 
+Version: 0.14.0-9000 [2015-05-13]
+o BUG FIX: rowAnys(x, value, na.rm=FALSE) did not handle missing
+  values in a numeric 'x' properly.  Similarly, for non-numeric
+  and non-logical 'x', row- and colAnys(), row- and colAlls(),
+  anyValue() and allValue() did not handle when 'value' was a
+  missing value.  Thanks to Dongcan Jiang (Peking University,
+  China) for these bug fixes and corrsponding package tests.
+
+
 Version: 0.14.0 [2015-02-13]
 o ROBUSTNESS/TESTS: Package tests cover 96% of the code (was 91%).
 o CONSISTENCY: Renamed argument 'centers' of col- and rowMads() to

diff --git a/tests/rowAllAnys.R b/tests/rowAllAnys.R
@@ -172,7 +172,7 @@ for (value in c("g", NA_character_)) {
 # NA 0 test
 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
 x <- matrix(0, nrow=3, ncol=3)
-x[1,] <- c(NA, NA, 0)
+x[1,] <- c(NA_real_, NA_real_, 0)
 x[3,] <- c(1, 0, 1)
 
 r0 <- rowAnys_R(x, value=0)