-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in makeClusterPSOCK() on CRAN MacOS environments #62
Comments
What's the package? |
Hi, @HenrikBengtsson. The package is I am using |
How do you see that error message on https://cran.r-project.org/web/checks/check_results_sparrpowR.html? Basically, how do you know it's that error?
Did you mean |
@HenrikBengtsson Yes, I am using Unfortunately, the CRAN checks only show the first 13 lines. When I run the package on the rhub MacOS environment I can find some additional diagnostic information in the testhat.Rout.fail file within the artifacts. I include the full error traceback here (after some textual clean-up):
|
I've managed to reproduce this with a minimal package example, cf. https://github.com/HenrikBengtsson/teeny/runs/3076390940?check_suite_focus=true. This is R bug 18119 kicking in because the tcltk package is loaded, which it is when your package is attached. WorkaroundI've updated parallelly (>= 1.26.1-9002) to detect tcltk and force Until that version is on CRAN, add the following to your ## WORKAROUND: Avoid R bug 18119 [1] that is trigger when for instance the
## 'tcltk' package is loaded on macOS, or when running in the RStudio Console
## [1] https://bugs.r-project.org/bugzilla/show_bug.cgi?id=18119
if (getRversion() >= "4.0.0" && getRversion() <= "4.1.0") {
options(parallelly.makeNodePSOCK.setup_strategy = "sequential")
} That should fix it for you. Let me know how it goes. |
* Following advice from `future` package maintainer, now `spatial_power()` and `jitter_power()` functions reset future strategy when exiting * Addressed ERROR in MacOS CRAN environments by setting the `parallelly.makeNodePSOCK.setup_strategy = sequential` for MacOS environments running `tcltk` until `parallelly` (>=1.26.1-9002) is on CRAN. This workaround was suggested by the `parallelly` maintainer <HenrikBengtsson/parallelly#62 (comment)>
* Removed `LazyData: true` from 'DESCRIPTION' file because the package has no data accessed via a `data()` command and has no `data/` directory (in response to CRAN NOTE: 'LazyData' is specified without a 'data' directory) * Following advice from `future` package maintainer, now `spatial_power()` and `jitter_power()` functions reset future strategy when exiting * Addressed ERROR in MacOS environments on rhub by setting the `parallelly.makeNodePSOCK.setup_strategy = sequential` for MacOS environments running `tcltk` until `parallelly` (>=1.26.1-9002) is on CRAN. This workaround was suggested by the `parallelly` maintainer <HenrikBengtsson/parallelly#62 (comment)>
Thanks, @HenrikBengtsson. I have made the changes to my |
Did the CRAN team reach out to you asking to fix this as soon as possible, or did you notice the problem yourself? |
@HenrikBengtsson, I noticed the problem on my own after v0.2.2 release binaries were built in June 2021. I have not heard from the CRAN team. |
The fix seems to work for MacOS environments but now there is an error for Linux Debian and Fedora environments. sparrpowR check results This time I was contacted by the CRAN team. |
Hi. Can you please open a new issue for this; this is most likely different from this issue. Also, since it's not clear what version of parallelly those CRAN checks ran on, can you reproduce this on R-Hub? |
I am a maintainer for a package the Imports the
future
package and I have a CRAN RMD Error that was traced toparallelly::makeClusterPSOCK()
This error only appears on CRAN MacOS environments and throws no errors on other CRAN environments. Based on your note "a bug in R (>= 4.0.0 && <= 4.1.0) causing the new setup_strategy = "parallel" to fail in the RStudio Console on some systems" from
parallely
1.26.1 release I tried adding:to my testthat script, but the error was thrown on the rhub macos server (CRAN configuration) used for checking.
If I add:
to my testthat script the rhub macos server throws no error. When I check the package on my local MacOS environment (R version 4.1.0,
parallelly
version 1.26.1,future
version 1.21.0) the checks are clean so I suspect this may be a CRAN issue. Any insight on this error would be much appreciated, thank you!The text was updated successfully, but these errors were encountered: