Wrong order of arguments to sprintf in reporting connection failures

[kevinushey]

Here:

parallelly/R/makeClusterPSOCK.R

Lines 260 to 263 in cb62392

	stop(sprintf(ngettext(failed,
	"Cluster setup failed (connectTimeout=%.1f seconds). %d worker of %d failed to connect.",
	"Cluster setup failed (connectTimeout=%.1f seconds). %d of %d workers failed to connect."),
	failed, connectTimeout + 5, length(cl)))

I believe connectTimeout + 5 should be coming first.

[HenrikBengtsson]

Thank you. Two reproducible examples with different outcomes:

> cl <- parallelly::makeClusterPSOCK(2L, rscript_startup = quote(Sys.sleep(6.0)), connectTimeout = 0.0)
Error in parallelly::makeClusterPSOCK(2L, rscript_startup = quote(Sys.sleep(6)),  : 
  Cluster setup failed (connectTimeout=2.0 seconds). 5 of 2 workers failed to connect.

and

> cl <- parallelly::makeClusterPSOCK(2L, rscript_startup = quote(Sys.sleep(6.0)), connectTimeout = 0.1)
Error in sprintf(ngettext(failed, "Cluster setup failed (connectTimeout=%.1f seconds). %d worker of %d failed to connect.",  : 
  invalid format '%d'; use format %f, %e, %g or %a for numeric objects

Fixed in commit 0e94e25.

[kevinushey]

Thank you for taking a look so quickly!

[HenrikBengtsson]

Fixed version now on CRAN

[kevinushey]

Thanks again for taking a look so quickly!