Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash: port4me --include=<invalid> should produce an error #69

Closed
3 tasks
HenrikBengtsson opened this issue Jan 10, 2024 · 2 comments
Closed
3 tasks

Bash: port4me --include=<invalid> should produce an error #69

HenrikBengtsson opened this issue Jan 10, 2024 · 2 comments
Labels
bug Something isn't working language:bash
Milestone
0.7.0

Comments

@HenrikBengtsson
Copy link
Owner 

$ port4me --include=foobar

does not give an error. Instead, the value is silently ignored.

Action

  • Add CLI test
  • Add unit test
  • Fix bug in Bash
@HenrikBengtsson HenrikBengtsson added bug Something isn't working language:bash labels Jan 10, 2024
@HenrikBengtsson HenrikBengtsson added this to the Next release milestone Jan 10, 2024
@HenrikBengtsson
Copy link
Owner Author

Same for --skip=<invalid>.

HenrikBengtsson added a commit that referenced this issue Jan 10, 2024
@HenrikBengtsson
BUG FIX: port4me --prepend=<ports> would sort <ports>
dd3d39b 
BUG FIX: port4me --include=<invalid> would not give an error [#69]
HenrikBengtsson added a commit that referenced this issue Jan 10, 2024
@HenrikBengtsson
BUG FIX: port4me --skip=<invalid> would not given an error [#69]
b941134
@HenrikBengtsson
Copy link
Owner Author

Both fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language:bash
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@HenrikBengtsson