Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at working code. #36

Merged
merged 2 commits into from Apr 15, 2014

Conversation

latentflip
Copy link
Contributor

Another go, not beautiful, but handles all the edge cases I can throw at it:

  • normal blur without submit (run email validation)
  • click submit (run full form validation)
  • press down on submit button, but drag off (run email validation only, no submit)
  • press down on submit button, but drag off outwith browser chrome (run email validation only, no submit)

@wraithgar wraithgar mentioned this pull request Apr 14, 2014
@wraithgar
Copy link
Contributor

Well the tests pass and the behavior is what I expect in Chrome latest.

+1 From me, will want to sit on this a day to think about it cause I really hate this stinking bug.

@wraithgar
Copy link
Contributor

This would finally close #19

@wraithgar wraithgar mentioned this pull request Apr 15, 2014
@wraithgar
Copy link
Contributor

Thanks for getting to this. It's less janky than every other option we looked at, and you even added to the demo.html file!

@wraithgar wraithgar merged commit 1ba902f into HenrikJoreteg:master Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants