Add esm version #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[index.js] Replace `module.exports` with `exports.default`
[rollup.config.js] Produce a umd version of the script as `feather-route-matcher.js` Also produce a minified version as `feather-route-matcher.js` Enable source maps for both Add rollup and required plug ins as dev dependencies [package.json]
[feather-route-matcher.*.js] Compile index.js to umd [feather-route-matcher.js] Add minified version [feather-route-matcher.min.js] Add source maps
[test.js]
[package.json]
[package.json, README.md] - Append change log - Set version to 3.1.0
|
thanks for making this easy :) published to npm as 3.1.0 |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request proposes to (1) add an esm export to the script, (2) compile umd versions from that via rollup and (3) point to the appropriate versions via package.json's main and module fields. So this should be non-breaking.
Context: The library is being used in an upcoming example / tutorial on client side routing here: https://github.com/foxdonut/meiosis/blob/master/docs/lessons/routing.md
Being able to directly import the script into a browser would be awesome as per this discussion: https://gitter.im/foxdonut/meiosis?at=5cdd87b375d9a575a6f0a284