Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues reported by Aaron Yoshitake #66

Open
HenrikJoreteg opened this issue Jan 5, 2015 · 0 comments · May be fixed by #67
Open

Issues reported by Aaron Yoshitake #66

HenrikJoreteg opened this issue Jan 5, 2015 · 0 comments · May be fixed by #67
Labels

Comments

@HenrikJoreteg
Copy link
Owner

Chapter 7 - Views and the DOM:
renderCollection example and preceding text: The preceding text doesn't mention renderCollection's third argument - container - and does mention the fourth argument - options - while the actual example passes a container but no options.

Chapter 12 - Settings and Configs:
First sentence of "Security caveats": "Please avoid if sending any valuable settings across the wire this way".

The "if" should be omitted.

Chapter 13 - Caveats/Gotchas:

First sentence of "Function bindings": "The most common thing I see when teaching people JavaScript, even people who have been working with jQuery for a long time, is understanding how function execution works in JavaScript."

This must be missing a word or two; if I take out the middle part it reads "The most common thing I see.. is understanding how function execution works in JavaScript". This doesn't make sense in context; I believe you meant to say people don't understand how function execution works.

Numbering in "Function bindings": all "four ways to call a function" are numbered 1.

@bear bear added the bug label Jan 5, 2015
airandfingers added a commit to airandfingers/human-javascript that referenced this issue Jan 5, 2015
Fix description and example of renderCollection arguments per [renderCollection docs](http://ampersandjs.com/docs#ampersand-view-rendercollection), fixing HenrikJoreteg#66
airandfingers added a commit to airandfingers/human-javascript that referenced this issue Jan 5, 2015
airandfingers added a commit to airandfingers/human-javascript that referenced this issue Jan 5, 2015
Fix Chapter 13 part of HenrikJoreteg#66 by fixing wording of the first sentence and indenting JavaScript code blocks to not interfere with numbered list.
airandfingers added a commit to airandfingers/human-javascript that referenced this issue Jan 5, 2015
@airandfingers airandfingers linked a pull request Jan 5, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants