Upgrade to Preact X #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashcap
commented
Aug 21, 2019
| export const Provider = (props) => { | ||
| const store = props.store | ||
| const rest = {} | ||
| Object.keys(props).forEach((key) => { |
There was a problem hiding this comment.
microbundle doesn't like the spread operator. Just do it manually here.
| } | ||
| }) | ||
|
|
||
| return h(StoreContext.Provider, Object.assign({ value: store }, rest)) |
There was a problem hiding this comment.
Map props.store to the context provider's expected prop, value.
| @@ -48,4 +56,8 @@ export const connect = (...args) => { | |||
| return h(Comp, Object.assign({}, props, state, this.actionCreators)) | |||
| } | |||
| } | |||
|
|
|||
| return (props) => h(StoreContext.Consumer, undefined, (store) => { | |||
There was a problem hiding this comment.
The only way to consume context in the new API is through the context Consumer or the useContext hook. This seems like the simplest solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextAPI, which this package uses to pass downstore. Aconnect-ed component doesn't appear to render at all!createContextexport and its consumer and provider.npm test!Note: This PR should probably correspond to changing
peerDependencies.preactto>=10.x.xin the package.json. I should be published to npm with anexttag or major version bump.