Fix regression in pc is own skill when a rogue/stalker with plagiarized skill logs off #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed skill logs off
csnv
force-pushed
the
fix/plagiarize-relog-regression
branch
from
ecacce2
to
a4cab2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
By submitting this Pull Request I confirm I have followed proper Hercules code styling and that I have read and understood the contribution guidelines.
Changes Proposed
Fixed regression introduced in a incorrect implementation of #14 in upstream Hercules (HerculesWS/Hercules#3298) causing skills that belong to the Rogue skilltree to not be correctly identified as plagiarized and, thus, not being properly cleaned when plagiarizing a separate skill.
Issues addressed: