Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the macro BUILD_APPLE_M1 set by configure prevents a PROPER universal build #17

Open
atncsj6h opened this issue Mar 1, 2024 · 2 comments

Comments

@atncsj6h
Copy link
Contributor

atncsj6h commented Mar 1, 2024

see
SDL-Hercules-390/hyperion#617

@atncsj6h
Copy link
Contributor Author

atncsj6h commented Mar 1, 2024

another point you might want to consider is the cacheline size
a simple modification to hmalloc.h will take care of it

        #error Invalid cache line size specified
    #endif
#else

  #if defined( __APPLE__ ) && defined( __arm64 )
    #define CACHE_LINE_SIZE 128
  #else
    #define CACHE_LINE_SIZE 64
  #endif
  
#endif /* CACHE_LINE_SIZE */


@atncsj6h atncsj6h changed the title using the macro BUILD_APPLE_M1 set by configure prevents a universal build using the macro BUILD_APPLE_M1 set by configure prevents a PROPER universal build Mar 1, 2024
@jmaynard
Copy link
Contributor

jmaynard commented Mar 1, 2024

Thank you, Enrico. I will make sure your fixes for this go in. Universal macOS builds are definitely a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants