Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
My first Commit in GIT; I hope it works well ;)
- Added a few of many more to come Malaya Port NPC's. - Fixed: http://hercules.ws/board/tracker/issue-5894-malaya-port/ Signed-off-by: Masao <masao@gmx.ch>
- Loading branch information
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome back Masao!
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in /re/.
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're aware of that, and it'll be moved whenever Masao has the time for it.
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the "Unidentified Creature" NPCs make no sense. When they display this dialogue,
mes "The unidentified creature gets a glimpse of you, blushes and then disappears.";or
mes "The unidentified creature looks at you and runs away.";...they invoke events that most times don't hide the correct NPC. Did you convert these incorrectly, or are they supposed to be wrong?
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I had no real clue what those Unidentified Creature NPC's were about in the first place, they didn't really do that much that would be needed for anything or useful for anything, except that you talk to them and then they start hiding and unhiding each other everytime you touch them.
But I can assure you I converted them correctly, that's exactly the way they should work and what they should do according to the official script I got them from.
fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"they start hiding and unhiding each other everytime you touch them"
Except... they don't. Perhaps a mistake in the official coding, if you're sure you converted it correctly? If so, I'd suggest adding at the end of "OnBingx2":
donpcevent strnpcinfo(0)+"::OnDisable";fe15780There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You converted the lines incorrectly; they do in fact follow a simple pattern. You can reference my version of the script: http://svn.code.sf.net/p/rathena/svn/trunk/npc/re/cities/malaya.txt