Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended Item Duplicate? #1191

Closed
ermanherman opened this issue Mar 9, 2016 · 12 comments
Closed

Unintended Item Duplicate? #1191

ermanherman opened this issue Mar 9, 2016 · 12 comments
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) type:bug Issue is a bug or describes an incorrect behavior that should be fixed

Comments

@ermanherman
Copy link

Hi there,

Today i just think about to investigate if any duplication may occur either intended by players or by system saving glitch.

Surprisingly i found there is duplication and from my conclusion it's unintended by players, since the item duplicate with same unique_id persists in players account without their acknowledge.

Here i do how to trace the duplicate item with unique_id

SELECT unique_id, account_id, nameid, refine
FROM storage 
GROUP BY unique_id
HAVING COUNT( * ) >=2

I tested on both my servers, 1 using kinda old hercules about 1 year ago version, and another one with at least 1 month old of hercules version.

Please check this guys and thanks.

Just some extra info the server running with about 300 players avarage.

@ermanherman
Copy link
Author

UPDATE:

Server not crash, just few hour from my checking there were found about 4407 duplicated uniqe_id items found and it rising to 4413 in STORAGE without clue...

@ermanherman
Copy link
Author

UPDATE:

Im tracking latest duplicated unique_item and talk to one of effected char. He said he just store the item and dont realize that item he stored become 2 in quantity although he store it 1.

@ermanherman
Copy link
Author

@dastgirp
Copy link
Member

dastgirp commented Mar 9, 2016

What was that item? Item Id? Was the item bounded? He stored in guild storage or account storage?

@ermanherman
Copy link
Author

Some screenshot.

1
2

@ermanherman
Copy link
Author

@dastgir mostly equipment. I cant check stack-able item due it dont have unique_id

@MishimaHaruna
Copy link
Member

Do you know if the server show any error message while running? (mostly interested in the ones tagged as [Error] or [SQL]).

Just to make sure, do you have more than one map-server connected to the same char-server?

@ermanherman
Copy link
Author

@MishimaHaruna no error sir, im running single map-server.

@ermanherman
Copy link
Author

@dastgir look like bound item not affected.

further investigation duplicated item found more in storage rather then inventory. Maybe STORAGE system having problem?

@kyeme
Copy link

kyeme commented Mar 9, 2016

I've experienced this, I'm just not sure if this was a Duplicate Item or there is some bug on UID. I've already sent this matter to @MishimaHaruna but he haven't read my message yet (I've sent a private message last June 2015, so this bug does exist for a long time already.)

@ermanherman
Copy link
Author

I belive this lead to item duplicate after i dig it deeper. It just happens without noone knows.

@hemagx hemagx added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:core Affecting the Hercules core (i.e. not the game mechanics directly) status:confirmed Issue is valid and can be reproduced labels Mar 9, 2016
MishimaHaruna added a commit that referenced this issue Mar 9, 2016
- Unique ID could get duplicated (resulting in an apparent item
  duplication, while it's only unique ID corruption). Fixees #1191
- Removed duplicated code (char_inventory_to_sql, being an almost exact
  clone of char_memitemdata_to_sql)

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna removed the status:confirmed Issue is valid and can be reproduced label Mar 9, 2016
@ermanherman
Copy link
Author

Thanks for fast action! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Development

No branches or pull requests

5 participants