-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest DB/Log is a total memory waste. #133
Labels
component:core
Affecting the Hercules core (i.e. not the game mechanics directly)
type:enhancement
Issue describes an enhancement or feature that should be implemented
Milestone
Comments
ghost
assigned MishimaHaruna
Nov 26, 2013
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Nov 27, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck. - Added some code documentation. Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Nov 27, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck. - Added some code documentation. Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Nov 27, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data. - Added some code documentation. - Thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Nov 27, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data. - Added some code documentation. - Thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
Merged
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Dec 1, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data. - Added some code documentation. - Thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
added a commit
to MishimaHaruna/Hercules
that referenced
this issue
Dec 3, 2013
- Improved memory usage of the quest log system. (saves up to 75kB per online character). Fixes issue HerculesWS#133. - Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data. - Added some code documentation. - Thanks to Ind. Signed-off-by: Haru <haru@dotalux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:core
Affecting the Hercules core (i.e. not the game mechanics directly)
type:enhancement
Issue describes an enhancement or feature that should be implemented
I'm currently going over my notebook and dumping things out of it as I see fit, this one is over a year old.
In every player instance (74.545 bytes):
map_session_data stands with 236.888 bytes, the quest feature alone consumes 1/3 of it, regardless if the player has 1000 or 0 quests.
The text was updated successfully, but these errors were encountered: