Bug 4718 / Official HP/SP handling

[shennetsind]

Thanks to Michieru for bringing it to my attention.
Originally brought up in: http://eathena.ws/board/index.php?autocom=bugtracker&showbug=4718
Regarding the SP/HP/JobData stuff in rathena/rathena@185b6b2 ( and select subsequent commits - https://github.com/rathena/rathena/commits/676d00796bf762564d3b693f3ae1ca7cd8edc6e4/db/pre-re/job_maxhpsp_db.txt )
I've been thinking and I don't think we should do like that at all, I'd like to propose revisiting all job configuration files and centralising some stuff, which intend to achieve a greater level of organisation and easier to customise, for example I'd like to throw out of the window:
(originally in player.conf)

// The time interval for HP to restore naturally. (in milliseconds)
natural_healhp_interval: 6000

// The time interval for SP to restore naturally. (in milliseconds)
natural_healsp_interval: 8000

// Automatic healing skill's time interval. (in milliseconds)
natural_heal_skill_interval: 10000

// Maximum atk speed. (Default 190, Highest allowed 199)
max_aspd: 190

// Same as max_aspd, but for 3rd classes. (Default 193, Highest allowed 199)
max_third_aspd: 193

// Maximum walk speed rate (200 would be capped to twice the normal speed)
max_walk_speed: 300

// Maximum HP. (Default is 1000000)
max_hp: 1000000

// Maximum SP. (Default is 1000000)
max_sp: 1000000

// Max limit of char stats. (agi, str, etc.)
max_parameter: 99

// Same as max_parameter, but for 3rd classes.
max_third_parameter: 120

// Same as max_parameter, but for baby classes.
max_baby_parameter: 80

// Same as max_parameter, but for baby 3rd's.
max_baby_third_parameter: 108

and have them be per-job data (wouldn't require it to be set numerous times, for example in the default build the settings would be defined in the base novice classes, and the later would inherit, however if anyone wanted for example for a hunter onwards to have greater param limits, they could modify it on the hunger level-entry).
This could also help issue #165 (by having the names and constants be in such a file as well).
I also would like to propose it be smart and not need things like:

sv_readdb(db_path, DBPATH"job_maxhpsp_db.txt", ',', 4, 4+MAX_LEVEL, CLASS_COUNT*2, &pc_readdb_job_maxhpsp);

which would require the file to be modified to add new entries whenever max_level is increased (great burden on the server admin)
neither

sv_readdb(db_path, DBPATH"job_basehpsp_db.txt", ',', 4, 4+500, CLASS_COUNT*2, &pc_readdb_job_basehpsp); //Make it support until lvl 500!

which would mean we'd be shipping custom values in the default build to no need. I'd like to propose simple yet clever way around: have the server auto-fill values not provided in the files by analysing the existent data, figuring what is the average increase per entry, and use that value to fill the subsequent missing entries (this would also solve the exp db thing where since athena it provides data up to level 999, and statsup that provides data up to 255).
and yes when I mention inherit I have something in the lines of the new skill tree in mind ( http://hercules.ws/board/topic/1188-skill-tree-db-redesign/ ). i'll be putting a draft forward, I welcome any and all feedback.

[Jedzkie]

Hi Ind! Any news on this stuff?

[malufett]

I want to work on this..but I love to ind do this..I'm not so familiar with lua type engine...Ind any news?