Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightmare Clock Tower Dungeon #1389

Closed
wants to merge 5 commits into from
Closed

Nightmare Clock Tower Dungeon #1389

wants to merge 5 commits into from

Conversation

Ridley8819
Copy link

@Ridley8819 Ridley8819 commented Aug 4, 2016

  • added mobs and (updated) skills
  • added quests_aldebaran.txt
  • iro dialogues
  • all items are already in available in item_db.conf
  • maps are already available in mapcache, index and .conf

Sources:
https://www.youtube.com/watch?v=W-cDlkq5aoE
http://ro.vrc7.net/?page_id=1326
http://www.divine-pride.net/database/map/c_tower2_
http://www.divine-pride.net/database/map/c_tower3_


This change is Reviewable

- added mobs and (updated) skills
- added quests_aldebaran.txt
- iro dialogues
- all items are already in available in item_db.conf
- maps are already available in mapcache, index and .conf
@MishimaHaruna MishimaHaruna added the status:code-review Awaiting code review label Aug 4, 2016
2923,Owl Marquees@NPC_EMOTION,chase,197,1,200,0,5000,yes,self,always,0,19,0xA1,,,,,
2923,Owl Marquees@NPC_EMOTION,idle,197,1,2000,0,5000,yes,self,always,0,6,0x37B5,,,,,
2923,Owl Marquees@NPC_SUMMONSLAVE,idle,196,2,10000,2000,60000,no,self,slavele,0,2921,,,,,,
3074,Time Holder@AL_TELEPORT,walk,26,1,5000,0,5000,yes,self,rudeattacked,,,,,,,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i know Time Holder doesn't have the teleport skill

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, i mixed something up here Oo

Staff_Of_Soul: 1
Menswear: 3
Sword_Stick: 1
Monocle_: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to kRO website it drops the item 18874 which in the item db Cyclops_Glasses !!

Cyclops_Glasses for Time Holder
Item  Combo Cyclops_Glasses, Memorize_Book, Pocket_Watch__
//= http://herc.ws - http://github.com/HerculesWS/Hercules
//=
//= Copyright (C) 2012-2016 Hercules Dev Team
//= Ridley
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//= Copyright (C) 2016  Hercules Dev Team
//= Copyright (C) 2016  Ridley

@Ridley8819
Copy link
Author

Review status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions.


db/re/mob_db.conf, line 82277 [r3] (raw file):

Previously, Asheraf (Acheraf Rian) wrote…

according to kRO website it drops the item 18874 which in the item db Cyclops_Glasses !!

Done.

npc/re/quests/quests_aldebaran.txt, line 13 [r1] (raw file):

Previously, MishimaHaruna (Haru) wrote…


//= Copyright (C) 2016  Hercules Dev Team

//= Copyright (C) 2016  Ridley

Done.

Comments from Reviewable

Time Holder Name
Item Effect for Pocket_Watch_ and Pocket_Watch__
Copyrights
mes("I'm begging you not to ask more about it. It might put your life in danger.");
next;
switch (select("Don't ask", "Go to 2nd floor of warped tower", "Go to 3rd floor of warped tower")) {
case 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe you should add tab before case as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/HerculesWS/Hercules/wiki/Coding-Style
Chapter 1, the one here Ridley used is correct

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I replied that to him too, but In a pm :x

@MishimaHaruna MishimaHaruna removed the status:code-review Awaiting code review label Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants