Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save near 200 places in arrays with size SC_MAX. #1817

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

4144
Copy link
Contributor

@4144 4144 commented Aug 10, 2017

SC_X conatants can be with any numbers.

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Save near 200 places in arrays with size SC_MAX.

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@4144 4144 added the status:code-review Awaiting code review label Aug 10, 2017
@guilherme-gm
Copy link
Member

If I recall correctly SC_DAILYSENDCOUNT is used by client to show the amount of messages you can send in the current day, so it uses that fixed ID

@dastgirp
Copy link
Member

Afaik, SC doesn't depend on client, might be something else?

@guilherme-gm
Copy link
Member

hmm SI does then? I thought the server sents sc ID to the client (and it would be a problem there: https://github.com/HerculesWS/Hercules/blob/master/src/map/rodex.c#L59 ) but seems to be fine, my bad

@dastgirp
Copy link
Member

I don't know how rodex works for that.
SI: Status Icon (the one displayed on right side)

@Lemongrass3110
Copy link
Contributor

@dastgir you are correct. Rodex works like every other SC. The SI is 824 and the mapping from SC to SI is what's important, because in clif it will look up the SI and send it to the client.

@guilherme-gm
Copy link
Member

Oh I see, didn't know that, thanks!

SC_X conatants can be with any numbers.
@MishimaHaruna MishimaHaruna merged commit 14b4873 into HerculesWS:master Aug 14, 2017
@4144 4144 deleted the reducememoryusage branch August 14, 2017 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code-review Awaiting code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants