Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace msvc11 build files with msvc15 #2131

Merged
merged 2 commits into from Jul 24, 2018
Merged

Conversation

Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Jul 15, 2018

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

This will update the visual studio build projects as per supported platforms in https://github.com/HerculesWS/Hercules/wiki/Supported-Platforms

  • support for msvc11 is dropped
  • support for msvc15 is added (minimum windows sdk required 10.0.15063.0)

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

a minimum windows sdk version (10.0.15063.0) aka Windows 10 v.1703 is required for the new builds
@MishimaHaruna MishimaHaruna merged commit 182d504 into HerculesWS:master Jul 24, 2018
@Asheraf Asheraf deleted the msvc15 branch September 24, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants