Item Bind Complete #214
Item Bind Complete #214
Conversation
… crash. Im pretty sure its on the clif.c Signed-off-by: sevenzz23 <sevenzz23@yahoo.com>
Fixed, some issue thanks to Master Ind ;) Signed-off-by: sevenzz23 <sevenzz23@yahoo.com>
Signed-off-by: sevenzz23 <sevenzz23@yahoo.com>
| @@ -316,6 +316,13 @@ | |||
| 290: The player is no longer killable. | |||
| 291: Weather effects will dispell on warp/refresh | |||
| 292: Killer state reset. | |||
| //Item Bound System | |||
There was a problem hiding this comment.
These strings could use some grammar review... (you 'bind' the items, so that they become 'bound' to the account/character/whatever; you don't 'bound' them, so that they become 'bounded' to an account/char/etc...)
|
There seem to be some critical flaws in how |
|
I having problem in changing mapif_parse_itembound_retrieve to mapif_parse_ItemBoundRetrieve When I try to change it, guild bounded items cant store anymore in guild storage. |
| @@ -52,8 +52,8 @@ | |||
| -1,10,-1,14, 14,19, 6,-1, 14,14, 0, 0, 0, 0, 0, 0, // 3020- Party | |||
| -1, 6,-1,-1, 55,19, 6,-1, 14,-1,-1,-1, 18,19,186,-1, // 3030- | |||
| -1, 9, 0, 0, 0, 0, 0, 0, 7, 6,10,10, 10,-1, 0, 0, // 3040- | |||
| -1,-1,10,10, 0,-1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, // 3050- Auction System [Zephyrus] | |||
| 6,-1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, // 3060- Quest system [Kevin] [Inkfish] | |||
| -1,-1,10,10, 0,-1, 12, 0, 0, 0, 0, 0, 0, 0, 0, 0, // 3050- Auction System [Zephyrus] [Mhalicot] | |||
There was a problem hiding this comment.
- Extra space before the
12that breaks alignment on the rest of the line - Comment is no longer correct, since it's no longer Auction System alone.
| @@ -212,6 +212,7 @@ struct NORMALITEM_INFO { | |||
| #endif | |||
| #if PACKETVER >= 20080102 | |||
| int HireExpireDate; | |||
| unsigned short bindOnEquipType; | |||
There was a problem hiding this comment.
Are you positive? Won't adding two bytes here break anything, if the packet length was already correct before?
|
@shennetsind , could you please comment about the security concerns we discussed earlier, if you don't mind? (I believe your knowledge of the char-map server data flow is better than mine, plus my headache is getting worse) |
|
oki will do |
| } | ||
| mapit->free(iter); | ||
| } | ||
| intif->itembound_req(char_id,aid,guild_id); |
There was a problem hiding this comment.
before calling this, a flag in guild_storage should be set to lock it so no one can add/remove items until the response comes back, otherwise in the case char-server lags the guild storage will be prone to exploits
There was a problem hiding this comment.
found out that itembound_req already sets a gstor->lock
Signed-off-by: sevenzz23 <sevenzz23@yahoo.com>
|
Alright I'll get to work on this. |
|
I'm in the process of making adjustments and updating your pull request with the latest modifications, please do not commit anything else otherwise my merging efforts will be wasted. |
Update to latest version
thanks to Master Ind for answering small issue :)
~ Topic: http://hercules.ws/board/topic/1198-please-implement-accound-bound-items/