Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map_zone_remove not actually removing flags #2247

Merged
merged 2 commits into from Nov 14, 2018
Merged

fix map_zone_remove not actually removing flags #2247

merged 2 commits into from Nov 14, 2018

Conversation

Helianthella
Copy link
Member

Pull Request Prelude

Changes Proposed

map_zone_remove is supposed to remove all mapflags from a map that were added by a zone, but instead just re-applies them (wtf?). this PR makes it actually disable them by passing the off argument

This should fix #2242

@Helianthella Helianthella added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:core Affecting the Hercules core (i.e. not the game mechanics directly) severity:4-high Crashes and general instability status:needs-testing More testing is required labels Oct 2, 2018
@Helianthella Helianthella added this to the Release v2018.10.21 milestone Oct 2, 2018
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Helianthella Helianthella mentioned this pull request Oct 2, 2018
Closed
3 tasks
@Helianthella Helianthella removed the status:needs-testing More testing is required label Oct 3, 2018
MishimaHaruna
MishimaHaruna requested changes Oct 21, 2018
View reviewed changes
src/map/map.c Show resolved Hide resolved
@MishimaHaruna MishimaHaruna merged commit 3a6892f into HerculesWS:master Nov 14, 2018
@Helianthella Helianthella deleted the pkreload branch November 14, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) severity:4-high Crashes and general instability type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Milestone
Release v2018.11.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Helianthella @HerculesWSAPI @MishimaHaruna