Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some item db placeholders #2280

Merged
merged 1 commit into from Oct 22, 2018
Merged

Add some item db placeholders #2280

merged 1 commit into from Oct 22, 2018

Conversation

Asheraf
Copy link
Contributor

@Asheraf Asheraf commented Oct 10, 2018 •
edited

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This adds place holders for 493 item from kRO

@Asheraf Asheraf added the component:databases Affecting the databases available in the db/ folder label Oct 10, 2018
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf Asheraf added this to the Release v2018.10.21 milestone Oct 12, 2018
@MishimaHaruna MishimaHaruna merged commit 0959225 into HerculesWS:master Oct 22, 2018
@Asheraf Asheraf deleted the itemplaceholders branch December 19, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
component:databases Affecting the databases available in the db/ folder
Projects
None yet
Milestone
Release v2018.10.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Asheraf @HerculesWSAPI @MishimaHaruna