Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retarget 10.0.15063.0 into 10.0.17763.0 for Visual Studio 2017 #2368

Merged
merged 1 commit into from Feb 19, 2019

Conversation

AnnieRuru
Copy link
Contributor

@AnnieRuru AnnieRuru commented Feb 11, 2019

Pull Request Prelude

Issues addressed

http://herc.ws/board/topic/16521-how-to-setup-offline-server-for-personal-development-use/?do=findComment&comment=90471
Thanks to utofaery !!

Currently Visual Studio 2017 default their Windows Platform Version at 10.0.17763.0
but Hercules uses 10.0.15063.0 ...
means we have to download additional 1.43GB just to compile Hercules

Changes Proposed

So change the Windows Platform Version into 10.0.17763.0,
so we don't have to download unnecessary stuff ...

Affected Branches

  • Master

Known Issues and TODO List

not really sure if this break anything ?
let's see what Travis says ... ALL GREEN ... probably means ok to do so

so we don't have to download additional 1.43GB unnecessary
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Asheraf Asheraf changed the base branch from stable to master February 19, 2019 18:10
@Asheraf Asheraf merged commit d496d89 into HerculesWS:master Feb 19, 2019
@MishimaHaruna MishimaHaruna added this to the Release v2019.03.10 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants