Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation for disable battleground respawn #2381

Merged
merged 1 commit into from Mar 10, 2019

Conversation

AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

Add missing documentation for disable battleground respawn

Tested with

... erm ...
https://github.com/AnnieRuru/customs/blob/master/scripts/bg_pvp_point_queue.txt
just change

	.red = bg_create_team( "guild_vs3", 13,50 );
	.blue = bg_create_team( "guild_vs3", 86,50 );

into

	.red = bg_create_team( "-", 13,50 );
	.blue = bg_create_team( "-", 86,50 );

Affected Branches

  • Master

Known Issues and TODO List

well, pressing the [Return to last Save Point] from the client side will forcefully leave the battleground team though

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru AnnieRuru added the component:documentation Affecting the documentation in the doc/ folder label Feb 19, 2019
doc/script_commands.txt Outdated Show resolved Hide resolved
@Emistry Emistry added the component:core:scriptengine Affecting the script engine or the script commands label Feb 26, 2019
- fix a minor bug that bg_create_team should return -1, as mentioned in doc/script_commands.txt
@AnnieRuru AnnieRuru added this to the Release v2019.03.10 milestone Feb 28, 2019
@AnnieRuru AnnieRuru removed the component:core:scriptengine Affecting the script engine or the script commands label Mar 2, 2019
@MishimaHaruna MishimaHaruna merged commit 28eb508 into HerculesWS:master Mar 10, 2019
@AnnieRuru AnnieRuru deleted the 60-bg_norespawn branch March 10, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:documentation Affecting the documentation in the doc/ folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants