New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional parameter for *gettimestr #2388
Conversation
083f10d
to
0313b5b
Compare
curious, isn't that after using |
if string next pushed to script engine as string and not cont, script engine will free it if need remove from memory |
hmm ... for some reason this isn't merge ... |
btw, cant we make the script command auto calculate the |
hmm ... the person who made this script command probably has die hard habit from C language then how do you want to modify it ? this is actually a copy paste from rathena, literally if we make the changing this behavior silently is big no-no ... |
that doesn't meant we aren't allow to change it or update it? Both rA/Herc and any other emulators has done it countless time. So its not a restriction. what I meant in previous post are totally remove the For example: changing the code to auto determine the length ?
into
if worry about the length aren't enough for that specific format, then just use the max length allowed.
So far only 2 scripts are using it. That's why changelog/commit history exists for a reason. For user to read/keep track of what has been changed. Every milestone release come with a changelog for each release. |
I'm not doing that, because your format won't throw error on old scripts |
0313b5b
to
ff833bd
Compare
just noticed the documentation says |
ff833bd
to
b478fb0
Compare
Pull Request Prelude
Issues addressed
we have
*getcalendartime
script command, but why our*gettimestr
isn't update for it?Changes Proposed
Add optional parameter for
*gettimestr
Tested with
which is stated in the documentation
Affected Branches
Known Issues and TODO List
none
in fact this is mostly a copy-paste from rathena repo