Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter for *showscript to send target to SELF only #2415

Merged
merged 2 commits into from Apr 7, 2019

Conversation

AnnieRuru
Copy link
Contributor

Pull Request Prelude

Issues addressed

as requested by Kuroe, add optional parameter to allow *showscript to only shown to the player

Changes Proposed

  • Add optional parameter for *showscript to send target to SELF only
  • also remove the useless script_pushint

Affected Branches

  • Master

Known Issues and TODO List

this is copy paste from rathena

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru
Copy link
Contributor Author

how to do the HPM Hook update ?
or have to do it manually ?

@4144
Copy link
Contributor

4144 commented Mar 30, 2019

how to do the HPM Hook update ?
or have to do it manually ?

run make in tools/HPMHookGen

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna added this to the Release v2019.04.07 milestone Apr 7, 2019
@MishimaHaruna MishimaHaruna merged commit a3a1e36 into HerculesWS:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants