New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move questinfo data from map to npc_data #2433
Conversation
@AnnieRuru can you check if this fixes your problem. |
no, still the same
note the line number is different than in the issue, as I have apply your patch also you can test it yourself by type atcommand
|
c501b6f
to
74dd125
Compare
@AnnieRuru this should fix the memory leak for now, but seems like I found another "bug" i will try to do an update later, hopefully before next release date. |
EDIT: yeah stupid me should've notice the line number is same as in the issue, means I didn't compile |
@AnnieRuru I am following the steps you gave to reproduce this and not getting any leaks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooopsie ~ yeah ... I forgot to compile hahaha
tested with some of my other custom quest log script, didn't see any leak anymore
74dd125
to
3f133b5
Compare
3f133b5
to
c699658
Compare
@AnnieRuru I have moved this around to fix a bug i missed last time, memory leaks should be fixed too, let me know if you find other problems. |
this will fix the issue where having multiple `questinfo()` blocks wont work properly
Pull Request Prelude
Issues addressed
#2431
Changes Proposed
fix memory leak in setquestinfo