Update minimum value of *input script command. #2494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
All
input()
shall have default values, especially old scripts.Maybe consider to set all parameter for
input()
as mandatory?How to reproduce:
https://github.com/HerculesWS/Hercules/blob/stable/conf/map/script.conf
talk to any NPC that use
input()
to exchange item/zeny/points and enter negative values to cause the exploit. (Ex:points = (points - (-amount));
becamepoints = (points + amount);
Issues addressed:
input()
script commands.https://github.com/HerculesWS/Hercules/blob/stable/npc/other/arena/arena_room.txt#L1008-L1035
arena_points
orZeny
in other scripts.Other Issue:
input()
doesn;t allow negative, so I am not sure why some NPC does/doesn't check for negative value. Hence it might affect minor NPC that has the if-else checking for negative value.