Disable refresh atcommand when talk with NPC. #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using `@refresh` during NPC conversation will caused player stucked due to unable to close the NPC dialog that no longer visible.
Emistry
added
the
component:core
|
This change is |
4144
approved these changes
Jul 9, 2019
MishimaHaruna
approved these changes
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
@refresh/@refreshallduring NPC conversation will caused player stucked due to unable to close the NPC dialog that no longer visible.@refreshshall display failure message if interact with NPC.@refreshallshall skip the player if the target player are interact with NPC.Issues addressed: