Function types behaviour

[panikon]

Updated return values of some atcommands.
Altered many function types from int to bool(C99) and added meaningful return values.
Altered many function types from int to void as they didn't have any meaningful return value.
Replaced chrif_char_offline with a macro as this function did exactly the same as chrif_char_offline_nsd.

[shennetsind]

Hi.
Thank you for your contribution its much appreciated.
I have a point I'd like to bring up, you've modified chrif_parse's return value however that is a RecvFunc type and since all the others passed untouched, it'd be a type mismatch error

typedef int (*RecvFunc)(int fd);

        session[chrif->fd]->func_parse = chrif->parse;

I'd ask you to revert that for the sake of the remainder of your pull request, so we can merge it as soon as possible to avoid any conflicts future commits may cause to it (and we can see about the recvtype stuff afterwards).
There are two other things, the chrif.h interface members for char_ask_name_answer and changemapserverack are not matching their chrif.c functions.
Once again thank you for your contribution, looking forward to the revisions.

[panikon]

Sorry about those mistakes in those interface members, there wasn't any errors or warnings when I built and usually when there were any mismatches between members and their functions there were, so I didn't even recheck them. I already changed those errors and sent a patch. https://github.com/panikon/Hercules/commit/761d3eb8291c997a627dc42da39913eb52abfce3
Thank you for your time.

[MishimaHaruna]

Careful here, there's still a chrif_check(-1) (line 254) that returns -1

[MishimaHaruna]

Hello! Thanks for your contribution. There are a few more little things I pointed out, if you could fix those, I believe we can merge it

[panikon]

Thank you for pointing out those mistakes, I corrected them and already pushed https://github.com/panikon/Hercules/commit/0267cad28133b4c245f1cf100a24ab8a14cf2a73

[MishimaHaruna]

Merged. Thank you again!