Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equipment auto bonus trigger #2514

Merged
merged 1 commit into from Aug 25, 2019
Merged

Fix equipment auto bonus trigger #2514

merged 1 commit into from Aug 25, 2019

Conversation

Emistry
Copy link
Member

@Emistry Emistry commented Jul 29, 2019 •
edited

Pull Request Prelude

Changes Proposed

  • fix auto bonus doesn't trigger for costume/shadow gears
  • fix pos always obtained 0 due to short data type.

Issues addressed:
fixes #1355
fixes #1190
fixes #2451

@Emistry Emistry added type:bug Issue is a bug or describes an incorrect behavior that should be fixed component:core Affecting the Hercules core (i.e. not the game mechanics directly) status:confirmed Issue is valid and can be reproduced labels Jul 29, 2019
@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@Emistry
Fix equipment auto bonus
00aa0bc 
- fix auto bonus doesn't trigger for costume/shadow gears, due to `pos`
always `0`.
- fixes HerculesWS#1355
@MishimaHaruna MishimaHaruna added this to the Release v2019.08.25 milestone Aug 25, 2019
@MishimaHaruna MishimaHaruna merged commit 7c25f7e into HerculesWS:master Aug 25, 2019
@Emistry Emistry deleted the pc_addautobonus branch August 26, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4144 4144 4144 approved these changes

@MishimaHaruna MishimaHaruna MishimaHaruna approved these changes

Assignees
No one assigned
Labels
component:core Affecting the Hercules core (i.e. not the game mechanics directly) status:confirmed Issue is valid and can be reproduced type:bug Issue is a bug or describes an incorrect behavior that should be fixed
Projects
None yet
Milestone
Release v2019.08.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Emistry @HerculesWSAPI @4144 @MishimaHaruna