Fix for https://github.com/HerculesWS/Hercules/issues/2349.

[Kenpachi2k13]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

ipban_log() only inserts the first 3 octets of an IP and an asterisk for last one, so we can set the columns length of list in ipbanlist table to 13.

Issues addressed: #2349

[dastgirp]

add this in main.sql too (INSERT for sql_updates)

[Kenpachi2k13]

My mistake, sorry. Done!

[4144]

in this pr also useless merge commit

[pazkero]

Question, some custom plugins which I've saw on the forums add a command called "@ipban", for example, which is a non-automatic way of adding IP Bans.

An IP official length is 15 or 16 (xxx.xxx.xxx.xxx). Wouldn't this cause issues when IP bans are not done automatically? (Also, in some rather specific cases, it might be a desired behavior to ban only the specific IP. Yes, I am aware of how dynamic IP works and why we usually use a star.)

TL;DR Doesn't this causes issues or SQL errors if there are IP Bans of length 15?

PS. Feel free to open an issue about it, if you think it relevant. I'm just curious.

[dastgirp]

@pazkero
If you see the source, we always add only 3 octet and wildcard

ipban.c:

if (SQL_ERROR == SQL->Query(ipban->sql_handle, "INSERT INTO `%s`(`list`,`btime`,`rtime`,`reason`) VALUES ('%u.%u.%u.*', NOW() , NOW() +  INTERVAL %u MINUTE ,'Password error ban')",
			ipban->dbs->table, p[3], p[2], p[1], login->config->dynamic_pass_failure_ban_duration))

As you can see here, the value inserted is '%u.%u.%u.*'.

I don't know why this is done. Also for custom source, I guess you would need to manually change sql for now. I will open the issue on your behalf as you have mentioned it.