Update packets up to 2019-12-11 #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
force-pushed
the
updatepackets
branch
2 times, most recently
from
9d6865d
to
cfb0a96
Compare
4144
force-pushed
the
updatepackets
branch
2 times, most recently
from
bd912e1
to
909ebe1
Compare
Kenpachi2k13
requested changes
Dec 7, 2019
Kenpachi2k13
approved these changes
Dec 8, 2019
dastgirp
reviewed
Dec 8, 2019
|
|
||
| Works same as specialeffect but also send effect numbers to client. | ||
| For PACKETVER >= 20191127 support two numbers (num1, num2). | ||
| For older packet versions only num1 supported. |
There was a problem hiding this comment.
num2 is high dword of num. Script engine not support int64, because this here num and num2. Inside packet its one int32 or one int64 depend on packet version
MishimaHaruna
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Update packets table up to 2019-12-11.
Update shuffle packets up to 2019-12-11.
Update packets keys up to 2019-12-11.
Update packet ZC_NOTIFY_EFFECT3 to new version.
Update packet CZ_SE_CASHSHOP_OPEN to new version.
Add script function specialeffectnum.