Fixes mistreatment of int return from Asura Strike fixes #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4144
approved these changes
Feb 14, 2020
Kenpachi2k13
approved these changes
Feb 24, 2020
Kenpachi2k13
added
codereview:accepted
|
This was included as part of #2546 merged earlier today, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This changes the check added in #2248 for the return from
unit->moveposso it accepts anything!= 0astrue(as it originally was) instead of only the return value1.unit->moveposcurrently only returns 0/1, but as noted by @skyleo in #2248 (comment) , it could introduce an unexpected side-effect.Issues addressed:
Fixes #2629