Avoid warp system

[cannelle]

Added settings to prevent teleport from landing on portals and to prevent mobs from spawning on and walking onto warps.

[EPuncker]

I agree with it being implemented :)

[EPuncker]

please don't close this! I hope this is going to be implemented soon!

[cannelle]

You can still add it yourself, just look at files changed and add the edits. There was no response for a month so I assume Hercules is already planning an alternate solution to this problem or doesn't find this one adequate. The information is still here if anyone decides to include it or a derivative of it in the future.

[EPuncker]

they are just pretty busy, they always comment on pull requests, but that is your choice, thanks anyway!

[MishimaHaruna]

Sorry for not commenting on this before. As @EPuncker said, things have been a bit busy/slow this month, and work piled up.

We've reviewed this code, even if we've never commented here. We had some concern about the npc->check_areanpc() calls (it is a slow function, calling it twice in a loop condition might affect performance), but it probably is a necessary evil in this case.

If we're to implement it, though, I'd change it so that either avoid_warp and avoid_ontouch are split in two different settings each (one to handle mob walks/spawns and one to handle player teleports), since they're currently doing two different things, and if you just want to avoid players teleporting onto portals, you'll also get the performance penalty from checking for mobs walking onto portals, or I'd simply remove the mob walk part altogether, since it looks far less useful to me.

[EPuncker]

@cannelle they are alive now :P I hope you look into this again :D