Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression in the mob drop rate calculation #3083

Merged
merged 1 commit into from Nov 6, 2021

Conversation

MishimaHaruna
Copy link
Member

Pull Request Prelude

Changes Proposed

The value was accidentally always overridden to be 900%. With the intent to cap to 90%, max(rate, 90000) erroneously used instead of min(rate, 9000).

Issues addressed: N/A (reported in discord)

The value was accidentally always overridden to be 900%

Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna changed the base branch from stable to master November 6, 2021 16:56
@MishimaHaruna MishimaHaruna merged commit 29bc5ef into HerculesWS:master Nov 6, 2021
@MishimaHaruna MishimaHaruna deleted the drop-rate-fix branch November 6, 2021 16:57
@MrKeiKun
Copy link
Contributor

@MishimaHaruna why change to min? that means even if @iteminfo calculates it to 100% it will just drop to 90%
since before my PR it was drop_rate = max(drop_rate, cap_value((int)(0.5 + drop_rate * (sd->sc.data[SC_OVERLAPEXPUP]->val2) / 100.), 0, 9000)); which is max...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants