Add http support to hercules (api-server) #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add constant for char server name size.
This allow call for some time api functions after player disconnected from game.
Also add support for async data handlers for reply from char server. Add api interface in char server.
This flag set if http request already parsed but not disconnected.
Also add macro GET_DATA for get data pointer in api data handlers.
official clients sends this header and not handling it properly causes the client to hold the payload for some time, making the entire request take longer. Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
Providing an error code allows client some feedback to the user when the emblem gets rejected or something goes wrong in the middle of the process. Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
Not having data and a server error were both being handled as no data, which would lead a query error to overwrite user configs with defaults. We now send a proper error when it fails to load due to an application error. This makes official clients inform user about the issue and not override their configs. Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
providing a error status prevents clients from overriding their data with bad one, and also show a proper error message to the user. Signed-off-by: Guilherme G. Menaldo <guilherme.menaldo@outlook.com>
…ith unicode chars
Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
approved these changes
Apr 12, 2023
Signed-off-by: Haru <haru@dotalux.com>
Note: This was done without the VS IDE and comes with no guarantee that it'll work. My personal thought is that these files shouldn't be in the repository at all since the way they are is just unmaintainable unless one has several versions of VS installed and the patience to replicate each change to the project file in all the version. VS (and Xcode) project files shouldn't be part of the repository at all and should be replaced with definitions for a generator tool (i.e. CMake) that can generate projects for different IDEs that people might want to use. Signed-off-by: Haru <haru@dotalux.com>
MishimaHaruna
force-pushed
the
apiserver
branch
from
2e7f168
to
d6b30ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Add new server with name api-server for http requests from clients or other tools.
api-server listen by default on port 7121.
Visual studio projects can be incomplete.
for now supported this http features:
More information see in https://board.herc.ws/topic/20151-http-support-in-hercules-funding/