1st jobs skill rebalance (2018 patch/Renewal) #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
changed the title
guilherme-gm
force-pushed
the
old-job-rebalances-1
branch
from
2a5ef54
to
ad62835
Compare
skyleo
approved these changes
Jul 31, 2023
guilherme-gm
force-pushed
the
old-job-rebalances-1
branch
from
ad62835
to
ca83fd4
Compare
3 tasks
guilherme-gm
force-pushed
the
old-job-rebalances-1
branch
from
ca83fd4
to
dc5a7f9
Compare
guilherme-gm
force-pushed
the
old-job-rebalances-1
branch
from
dc5a7f9
to
0271432
Compare
- After skill delay reduced (2 seconds -> 0.5 seconds) - (already implemented) Added 2 seconds of Cooldown From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Change affected players (Caster-only -> All party members in screen range) - Effect changed: - Str +4 (kept as is) - Extra ATK +30 (new effect) - CastTime: None -> 1 second - FixedCastTime: None -> 0.5 seconds - CoolDown: None -> 30 seconds From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Fixed casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.2 seconds. - New: 0.2 + (Skill Level × 0.1) seconds Variable casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.8 seconds. - New: 0.2 + (Skill Level × 0.3) seconds Global delay of skills changed. - Old: 0.8 + (Skill Level × 0.2) seconds - New: 1.4 seconds at all skill levels. Values based in iRO Wiki From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Fixed casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.2 seconds. - New: 0.2 + (Skill Level × 0.1) seconds Variable casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.8 seconds. - New: 0.2 + (Skill Level × 0.3) seconds Global delay of skills changed. - Old: 0.8 + (Skill Level × 0.2) seconds - New: 1.4 seconds at all skill levels. Values based in iRO Wiki From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Fixed casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.2 seconds. - New: 0.2 + (Skill Level × 0.1) seconds Variable casting time changed. - Old: (0.4 + (Skill Level × 0.4)) x 0.8 seconds. - New: 0.2 + (Skill Level × 0.3) seconds Global delay of skills changed. - Old: 0.8 + (Skill Level × 0.2) seconds - New: 1.4 seconds at all skill levels. Values based in iRO Wiki From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Fixed casting time changed. - Old: (Skill Level × 0.8) x 0.2 seconds. - New: 1.5 seconds at all skill levels. Variable casting time changed. - Old: (Skill Level × 0.8) x 0.8 seconds. - New: 2.5 + (Skill Level × 0.2) seconds Values based in iRO Wiki From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Fixed casting time changed. - Old: 0.3 seconds at skill level 1-5, 0.2 seconds at skill level 6-10. - New: 0.2 seconds at all skill levels. Variable casting time changed. - Old: 1.2 seconds at skill level 1-5, 0.8 seconds at skill level 6-10. - New: 0.8 seconds at all skill levels. Global delay of skills changed. - Old: 1.5 seconds at skill level 1-5, 1.0 seconds at skill level 6-10. - New: 0.7 seconds at all skill levels. From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Global delay of skills changed. - Old: 1.2 - 2.7 seconds at skill level 1-10. - New: 1.4 seconds at all skill levels. From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
Global delay of skill changed: 1.5s -> 0.5s From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
calculating it outside sc_start and passing as level prevents any possible calculation over the original level, which is needed for blessing (given by AB_CLEMENTIA). Moving the calculation to sc_start logic both centralizes the bonus calculation in a single place and also allows us to calculate other values based in the expected level
- Also increases HIT +2 per skill level - Clementia also gives additional HIT +1 for each 10 job levels From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Also increases ASPD +1% per skill level - Canto Candidus also gives additional ASPD +1% for each 10 job levels From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Now increases +50 MaxHP per SkillLevel - The increased HP also gets healed - 30s cooldown added From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
- Fixed casting time changed: 0.4s -> 0.2s - Variable casting time changed: 1.6s -> 0.8s From massive skills rebalance (1st/2nd/transclass) (2018.10.31)
guilherme-gm
force-pushed
the
old-job-rebalances-1
branch
from
0271432
to
8f0fb32
Compare
|
I think this is ready for a real review, I made all the PRs up to the end of 2nd classes. I am not sure whether we should move this to master or put it in an "accumulation" branch until we have all the other PRs (and also the part for transclasses that I didn't make) merged. A few skills from Transclass bard/dancer may not play well with #3279 |
MishimaHaruna
approved these changes
Mar 30, 2024
|
I created a new This will allow anyone that feels like trying a preview of the (already reviewed and merged) rebalance changes to check out that branch, without disrupting those that rely on the stable version to be stable. I'll make a mention of this in the main release notes for the 2024.03 release I'm about to sign off |
MishimaHaruna
added a commit
that referenced
this pull request
Mar 30, 2024
Signed-off-by: Haru <haru@dotalux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Introduces the rebalance of the first jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 2nd jobs and transclass too. I am working in additional PRs for the 2nd jobs, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
References:
Issues addressed:
Closes #2725