Increased ASC_BREAKER range from 7 to 9 cells #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyleo
approved these changes
Nov 2, 2023
csnv
force-pushed
the
fix/soul-breaker-range
branch
from
f400507
to
da40ce6
Compare
Irowiki also lists 500ms. Done. |
|
Should split or reword the commit now that it doesn't only change range. |
Increased range from 7 to 9 cells in both, re and pre-re Decreased cast time from 700 to 500 in pre-re
csnv
force-pushed
the
fix/soul-breaker-range
branch
from
da40ce6
to
71e7a06
Compare
Done. |
MishimaHaruna
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
As expressed on the linked issue, the correct range for Soul Breaker/Destroyer is 9 cells instead of 7 cells for pre-re.
Gravity with its 2020 skill overhaul reduced this range in renewal to 4 cells. However, Hercules is not at that episode yet, so I've decided it's better to stay at 9 cells for renewal too.
Issues addressed:
#1104