Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script function return always removing references from NPC variables. #502

Merged
merged 3 commits into from
Apr 25, 2015

Conversation

k-py
Copy link
Contributor

@k-py k-py commented Apr 21, 2015

@MishimaHaruna MishimaHaruna self-assigned this Apr 21, 2015
@k-py k-py force-pushed the bugfix-return-getvariableofnpc branch from 0772f30 to 79aa56c Compare April 21, 2015 19:28
@k-py
Copy link
Contributor Author

k-py commented Apr 21, 2015

I removed an unnecessary check and rebased the branch.

@k-py
Copy link
Contributor Author

k-py commented Apr 22, 2015

After further testing, I uncovered a crash condition caused by the incorrect usage of return outside the scope of a function or subroutine.

-   script  test    -1,{
    return getvariableofnpc(.x, "test2");
}
-   script  test2       -1,{
    end;
}

Already fixed.

@MishimaHaruna
Copy link
Member

Thank you very much

MishimaHaruna added a commit that referenced this pull request Apr 25, 2015
Fix script function return always removing references from NPC variables.
@MishimaHaruna MishimaHaruna merged commit 0f7a793 into HerculesWS:master Apr 25, 2015
@k-py k-py deleted the bugfix-return-getvariableofnpc branch September 20, 2015 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants