Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explode() return array size. #699

Closed
wants to merge 3 commits into from
Closed

explode() return array size. #699

wants to merge 3 commits into from

Conversation

Emistry
Copy link
Member

@Emistry Emistry commented Sep 6, 2015

This special label triggers when a player's stats are recalculated, such
as when
changing stats, equipment, or maps, as well as when logging in, leveling
up, and
mounting a job mount. This can be used to grant additional item bonuses
to certain
player groups, for instance.
@Emistry
Copy link
Member Author

Emistry commented Sep 6, 2015

O__O ....my second pull request merged with this one .. lol ..
How do I separate it ?

@dastgirp
Copy link
Member

dastgirp commented Sep 6, 2015

Use branches @Emistry
First reset master branch with remote
Then for making sure you are on master
git checkout master
Then create new branch
git checkout -b BranchName
Apply your mods
Push as usual,
Then make PR with that branch.

(Tip: don't have edit master branch)

@Emistry
Copy link
Member Author

Emistry commented Sep 6, 2015

DELETED .. will recreate another PR.

@Emistry Emistry closed this Sep 6, 2015
@EPuncker
Copy link
Contributor

EPuncker commented Sep 6, 2015

and about that pcstatcalcevent, are you going to make PR for that?

@dastgirp
Copy link
Member

dastgirp commented Sep 6, 2015

I doubt that will ever be accepted.

@EPuncker
Copy link
Contributor

EPuncker commented Sep 6, 2015

that is why I asked xD it was suggested already and denied bcz too resource intensive

@Emistry
Copy link
Member Author

Emistry commented Sep 6, 2015

since it's denied, I am not going to create a pull request for it.
those users who want the patch can use the link above to get it =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants