Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bAddMaxWeight bonus for increasing player's max weight #898

Closed
wants to merge 1 commit into from

Conversation

AnnieRuru
Copy link
Contributor

I'm so amazed that my bAddMaxWeight bonus has been added in rAthena long time ago,
rathena/rathena@0b6c542
but nobody actually pull request here before

the reason is this
https://rathena.org/board/tracker/issue-8541-set-maxweight-item-script-error/

@MishimaHaruna MishimaHaruna added the status:inprogress Issue is being worked on / the pull request is still a WIP label Nov 28, 2015
@dastgirp
Copy link
Member

Why this isn't merged yet?

@dastgirp dastgirp added the status:code-review Awaiting code review label Dec 10, 2015
@AnnieRuru
Copy link
Contributor Author

don't ask me, ask one of the core developers
Ind has asked me to pull request anything that touch the source code,
until explicitly review by one of the core developer =/

the only thing I'm allow to is scripts

@hemagx
Copy link
Contributor

hemagx commented Dec 10, 2015

is it safe ?
the bonus is temporary and player can lose it and then become over actual weight?

@AnnieRuru
Copy link
Contributor Author

the idea is, having an item pouch as accessory to increase player maximum weight limit
and we have been doing MaxWeight += 10000; all this time,
until the bug report in rathena I linked to came out

yes its temporary
if the player unequip the item pouch having this bonus, they will become overweight
( and if 90% weight they can't attack anyway )
the idea is for the players who wants to increase their weight to spam more pots ...
yes this is custom ... already in rathena repo for a long time ...

@MishimaHaruna
Copy link
Member

Thank you! merged as 478776d

@MishimaHaruna MishimaHaruna removed status:inprogress Issue is being worked on / the pull request is still a WIP status:code-review Awaiting code review labels Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants