Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update react-scripts to 3.0.1 #5

Merged
merged 3 commits into from Jul 23, 2019

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 23, 2019

Problem

I didn't realize till after the fact there's a security vulnerability due to some lodash issues in the babel dependencies. react-scripts v3.0.1 fixes those.

Screen Shot 2019-07-22 at 5 36 12 PM

Approach

I first tested it by using create-react-hook then manually upgrading react-scripts in both the root and the example and it seemed to work. I also tested starting the example with the SKIP_PREFLIGHT_CHECK=true in the .env commented out to see if I could fix all the errors.

Solution

I was able to do so by updating the following dependencies:

  • react-scripts@3.0.0 => 3.0.1
  • babel-eslint@10.0.0 => 10.0.1
  • eslint@5.6.0 => 5.16.0

I tested this locally and everything seems to be working (tested default template with npm).

Screen Shot 2019-07-22 at 5 39 24 PM

Screen Shot 2019-07-22 at 5 40 00 PM

Notes

My thought is to still leave the .env in there just in case (doesn't hurt, right?).

Thoughts? 馃憤

P.S. - here is the demo code for the egghead course :) I'm going to be doing a livestream on Friday at 3pm MST.

@jsjoeio jsjoeio marked this pull request as ready for review July 23, 2019 00:41
@Hermanya Hermanya merged commit 1d475df into Hermanya:master Jul 23, 2019
@Hermanya
Copy link
Owner

Good catch! Thank you for upgrading these. Create-react-hook@2.6.18 is now up.

Regarding the .env, I think it's okay to leave it in 馃槃

Good luck on your live stream 馃憤

@Hermanya
Copy link
Owner

@jsjoeio I have recently read this thread facebook/react#15791 (comment) and over there Ryan Florence makes a point against the idea behind use-click-outside.

@jsjoeio jsjoeio deleted the jsjoeio/react-scripts-update branch July 23, 2019 03:04
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 23, 2019

@Hermanya thanks for meeting this so quickly and fixing the lock file!

And thanks for tagging me on that! Looks like I may need to rewrite some of the course material. I really appreciate you sharing that. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants