Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I didn't realize till after the fact there's a security vulnerability due to some
lodash
issues in the babel dependencies.react-scripts
v3.0.1
fixes those.Approach
I first tested it by using
create-react-hook
then manually upgradingreact-scripts
in both theroot
and theexample
and it seemed to work. I also tested starting the example with theSKIP_PREFLIGHT_CHECK=true
in the.env
commented out to see if I could fix all the errors.Solution
I was able to do so by updating the following dependencies:
react-scripts@3.0.0
=>3.0.1
babel-eslint@10.0.0
=>10.0.1
eslint@5.6.0
=>5.16.0
I tested this locally and everything seems to be working (tested
default
template withnpm
).Notes
My thought is to still leave the
.env
in there just in case (doesn't hurt, right?).Thoughts? 馃憤
P.S. - here is the demo code for the egghead course :) I'm going to be doing a livestream on Friday at 3pm MST.