Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift compiler error - Xcode 13 beta 3 #720

Closed
johnnysay opened this issue Jul 23, 2021 · 2 comments
Closed

Swift compiler error - Xcode 13 beta 3 #720

johnnysay opened this issue Jul 23, 2021 · 2 comments
Assignees
Labels

Comments

@johnnysay
Copy link

What did you do?

I tried to compile a project using Hero.

What did you expect to happen?

I expected the project to compile.

What happened instead?

I got the following compiler error in code using UIApplication.shared:
'shared' is unavailable in application extensions for iOS: Use view controller based solutions where appropriate instead.

For example in HeroTransition+Complete.swift line 90 :
UIApplication.shared.keyWindow?.addSubview(isPresenting ? fromView : toView)

General Information

  • Hero Version: 1.5.0, probably the latest one as well

  • iOS Version(s): 15.0

  • Swift Version: 5

  • Devices/Simulators: iPhone 12 mini

  • Reproducible in Examples? (Yes/No): No, I could not reproduce it on a brand new project.

@JoeMatt
Copy link
Collaborator

JoeMatt commented Jul 28, 2021

hm, I thought this has been fixed in a prior PR.

I'll look into it again. Thanks

@JoeMatt JoeMatt self-assigned this Jul 28, 2021
@JoeMatt JoeMatt added the bug? label Jul 28, 2021
@JoeMatt
Copy link
Collaborator

JoeMatt commented Jul 28, 2021

@johnnysay 1.6.0 should have fixed this actually.
#681

We're on 1.6.1 now. I'm going to close, re-open if you update to 1.6.x and still have issues.

@JoeMatt JoeMatt closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants