Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs are closed when clicking the buttons area #1931

Closed
arielj opened this issue Oct 22, 2022 · 1 comment · Fixed by #1933
Closed

Dialogs are closed when clicking the buttons area #1931

arielj opened this issue Oct 22, 2022 · 1 comment · Fixed by #1933
Assignees

Comments

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2022

Describe the bug

When clicking on the empty space at the left of the dialog's buttons, the dialog gets closed. The area marked in red here:
image

This shouldn't happen since the user is clicking inside the dialog.

Add logs

Nothing relevant

Steps to reproduce

  1. Do any action that triggers a Dialog component
  2. Click the empty space at the left of the buttons
  3. The dialog is closed

Expected behavior

The dialog should not be closed clicking that area.

Screenshots

No response

System Information

  • Heroic Version [e. g. 2.1.1]: happens in main and in beta

Additional information

No response

@arielj arielj self-assigned this Oct 22, 2022
@arielj arielj mentioned this issue Oct 22, 2022
4 tasks
@arielj arielj linked a pull request Oct 22, 2022 that will close this issue
4 tasks
@wbrtm
Copy link
Contributor

wbrtm commented Nov 1, 2022

Looks like this issue can be closed.

@arielj arielj closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants