Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dialog fixes #1933

Merged
merged 1 commit into from Oct 25, 2022
Merged

Some dialog fixes #1933

merged 1 commit into from Oct 25, 2022

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Oct 22, 2022

This PR fixes 3 issues with dialogs:

A comment on the last fix, the bug is present only when selecting text from different HTML elements, for example selecting text from the title and the content. That triggered a click event with the parent dialog as the target (since it can trigger an event with the 2 targets). To reproduce this issue before this fix, select text like this for example:
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 22, 2022
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team October 22, 2022 15:20
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽
that is for sure a pretty annoying thing.

@arielj arielj merged commit 3e8b7ca into beta Oct 25, 2022
@arielj arielj deleted the fixes/dialog-issues branch October 25, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialogs are closed when clicking the buttons area Uninstall dialog adds an empty space in grid
2 participants