Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroic does not respect launch arguments on custom added windows games (v2.5.0beta1) #1977

Closed
Kajot-dev opened this issue Nov 1, 2022 · 0 comments · Fixed by #1979
Closed

Heroic does not respect launch arguments on custom added windows games (v2.5.0beta1) #1977

Kajot-dev opened this issue Nov 1, 2022 · 0 comments · Fixed by #1979
Labels
bug:confirmed Something isn't working.

Comments

@Kajot-dev
Copy link
Contributor

Describe the bug

When adding custom game via "Add Game" button, Heroic does not respect (ignores) "launch arguments" setting.

Add logs

Not needed

Steps to reproduce

  1. Add any custom exetucable via "Add Game" button
  2. Add some launcher arguments (for example "-app" for Roblox)
  3. See in logs that Wine command does not contain launch arguments

Expected behavior

Expected Wine command:
/path/to/my/game.exe --my-custom args

Screenshots

No response

System Information

  • Manjaro 22.0.0 KDE Plasma 5.25.5,
  • Heroic Version v2.5.0.beta1:

Additional information

No response
flavioislima added a commit that referenced this issue Nov 2, 2022
@flavioislima
Fix Heroic does not respect launch arguments on custom added windows …
b520df1 
…games (v2.5.0beta1) #1977
@flavioislima flavioislima linked a pull request Nov 2, 2022 that will close this issue
[Fix] 2.5.0 Beta 1 Fixes #1979
Merged
4 tasks
@flavioislima flavioislima mentioned this issue Nov 2, 2022
Merged
4 tasks
@flavioislima flavioislima added the bug:confirmed Something isn't working. label Nov 2, 2022
flavioislima added a commit that referenced this issue Nov 3, 2022
@flavioislima
[Fix] 2.5.0 Beta 1 Fixes (#1979)
1a23c3c 
* fix: library item always selected

* chore: refresh library only if library is empty

* Fix Heroic does not respect launch arguments on custom added windows games (v2.5.0beta1) #1977

* fix: uninstalled recent games shown as installed

* fix: spacing on settings

* fix: broken gamepad

* fix: wine settings on windows

* fix: game settings route

* fix: enable language setting on default settings

* fix: pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:confirmed Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] 2.5.0 Beta 1 Fixes Heroic-Games-Launcher/HeroicGamesLauncher
2 participants
@Kajot-dev @flavioislima