Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] add .editorconfig, align text and icons in sidebar, fix sidebar shadow, sidebar css clean up #1105

Merged
merged 5 commits into from Mar 16, 2022

Conversation

dawidgarus
Copy link
Contributor

@dawidgarus dawidgarus commented Mar 13, 2022

  • Fixed drop shadow of the sidebar so it won't cover foreground elements in the main content
  • Aligned icons and labels in the sidebar. All labels start the same amount of pixels from the left now
  • Clean up of sidebar code, mostly CSS
  • Added .editorconfig - I figured that instead of changing my IDE configuration it's better to create .editorconfig as bonus for every contributor

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

Can you add screenshot? Would be good to remove some spacing from the submenu itens.

@dawidgarus
Copy link
Contributor Author

dawidgarus commented Mar 14, 2022

@flavioislima I've already changed spacing in the submenu items. Here's a screenshot:

Screenshot from 2022-03-14 17-45-31

I was also considering aligning submenu item labels with top level items but it would cause wrapping of the text for longer entries like unreal marketplace

EDIT: also, submenu for library looks like a submenu for store. Both were using different colors for active item, so I've changed it to accent color (yellow/orange)

@biliesilva
Copy link

biliesilva commented Mar 14, 2022

Is possible to give more margin-left or padding-left to Epic Store and GOG Store? They are submenus of Stores and is a UI convention to have submenus like this. An example for left space (not design, ignore the icon):
image

@dawidgarus
Copy link
Contributor Author

@bilianemoreira
I don't see any other submenus in the app, so I'm not sure where that convention comes from.
The problem with huge padding like this (as I mentioned before) is that it may cause text to wrap:
Screenshot from 2022-03-14 22-24-55
I'm not sure if that's desired behavior.

@flavioislima
Copy link
Member

Yes, I believe that we cannot give so much left padding because of some languages, otherwise, it will break words.

…cGamesLauncher into sidebar

� Conflicts:
�	src/components/UI/Header/index.css
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 16, 2022
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks for that!

@flavioislima flavioislima merged commit 5f03705 into Heroic-Games-Launcher:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants