[Fix] Not able to enable Steam Runtime #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imLinguin
added
the
pr:ready-for-review
| @@ -211,14 +211,14 @@ export default function OtherSettings({ | |||
| </span> | |||
| {isLinuxNative && ( | |||
| <span className="setting"> | |||
| <span className={classNames('toggleWrapper', { isRTL: isRTL })}> | |||
| <label className={classNames('toggleWrapper', { isRTL: isRTL })}> | |||
| <ToggleSwitch | |||
There was a problem hiding this comment.
Why changing from a span to a label fixes it?
Also, would be good to check the logic on the backend as well. To be sure it's using the right path.
There was a problem hiding this comment.
It was about not being able to handle the press event, label is being used in other check boxes as well.
flavioislima
approved these changes
Mar 14, 2022
dawidgarus
pushed a commit
to dawidgarus/HeroicGamesLauncher
that referenced
this pull request
Mar 15, 2022
dawidgarus
pushed a commit
to dawidgarus/HeroicGamesLauncher
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a easy fix.
Closes #1107
Use the following Checklist if you have changed something on the Backend or Frontend: