Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Dialogs hiding behind app window #1151

Merged
merged 1 commit into from Mar 23, 2022

Conversation

dawidgarus
Copy link
Contributor

Change dialogs (message boxes and file selection) to be modal (attached to window) so they will block application window until user closes dialog.

Sadly it doesn't work for file selection dialogs because of bug in electron: electron/electron#32857 but I expect it will work after they fix it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

Hi! thanks for another contribution!

My primary idea about those native dialogs would be to remove them all and use native <dialog> instead. So we could get the error from the backend and then show the message, or the question, on the frontend, using the current design, since native dialogs don't follow the app design.
so we could get a generic React component that could accept properties to show buttons for OK, YES, NO, etc. just like the natives are doing now.
Ofc the only exception would be the file dialog, but that's not an issue.

Although, since this solves an issue, we can merge this now and I will open a Github Issue for the future. Since I believe this would be a better solution to keep the design consistency. :)

@flavioislima flavioislima merged commit bb1bce0 into Heroic-Games-Launcher:main Mar 23, 2022
@flavioislima
Copy link
Member

Feature request:
#1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants