Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix install progress, install failling and no space error message #1203

Merged
merged 11 commits into from Apr 22, 2022

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Apr 12, 2022

Fix a regression that made GOG games fail to install on macOS as well.
Fix #1170
Fix #967 (probably, since the logs could not be accessed since the path was wrong due to having spaces on mac)
Add #1211
Got rid of react-context-menu that is deprecated and created a new component for that using MUI.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima requested review from CommandMC and imLinguin and removed request for CommandMC April 13, 2022 18:39
@flavioislima flavioislima changed the title [macOS] Fix install progress and no space error message [macOS] Fix install progress, install failling and no space error message Apr 13, 2022
electron/gog/library.ts Outdated Show resolved Hide resolved
electron/legendary/games.ts Outdated Show resolved Hide resolved
@flavioislima flavioislima linked an issue Apr 19, 2022 that may be closed by this pull request
@flavioislima flavioislima merged commit 599aa99 into main Apr 22, 2022
@flavioislima flavioislima deleted the fix_progress_mac branch April 22, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants